Hello,
I found a bug in the plugin that completely break the permissions for my forum admins.
If you are a user with some admin access on WPForo but are not a WP Admin, you can't access your admin pages anymore because of a bug in "wpforotpx.php" in the "admin_menu_order" function.
I've spent hours trying to understand what was wrong with my install as my forum admins and moderators told me they were getting an error saying "Sorry, you are not allowed to access this page." when trying to access their admin pages (ex: wpforo-settings)
If you are not a WP admin, you won't get the "Topic Prefix" submenu, and in return the "admin_menu_order" function will replace the $submenu global variable with an empty array, breaking the WP "user_can_access_admin_page" function.
I'm not sure about the best way to fix this, I just made a workaround to not unset the menu if the replacement is empty, but in my opinion, the issue is that people with WPForo "Full Access" should get access to the submenu in the first place.
So all in all, I believe the underlying issue is that the "wpforo_current_user_is" should check for the "fullaccess" permission when trying to see if someone is a forum admin. However, as I'm not sure what the implications would be, I didn't modify this function myself.
I would like my forum admin ("fullaccess") to be able to change the plugin settings like they are able to do for your other addons.
Regards.
