Exception in Advanced Member Search v1.0.3  

  RSS

pxt-wpforo-2018
(@pxt-wpforo-2018)
Active Member Customer
Joined: 9 months  ago
Posts: 7
09/01/2018 7:20 pm  

Dear wpForo,

Thank you for your excellent free plugin, which I am very happy with. The User Custom Fields addon that I have just purchased has multiple errors in its member search page. I am sure that if the first error were fixed, then your usual testing of the search results would shake out the remaining problems.

I am getting this error message:

Fatal error: Call to undefined method WpforoUcfDBManager::searchMembers() in /home/kwamukyw/public_html/wp-content/plugins/wpforo-user-custom-fields/includes/helper.php on line 439

I am using versions...

wpForo plugin version = 1.4.3

wpForo User Custom Fields version = 1.0.3

 

I see in another thread that there is a typo in the php code

searhMembers instead of searchMembers in dbManager.php

 When I correct that, I no longer get this exception, but then there are bugs in the search results.

This is what I did to create the issue:

  • In the User Fields Manager, create a custom text field
  • Add the custom field to the Account form and Member search form
  • Set the Member Search Type to Filter
  • In a profile, in the account form, set a value for the text field
  • In the Member search form, search on *any* field, or even with fields blank
  • Then the exception above is reported

 

 


ReplyQuote
Tom
 Tom
(@tomson)
Support Team Admin
Joined: 3 years  ago
Posts: 2744
10/01/2018 1:54 am  

Hi pxt-wpforo-2018

This problem is already fixed in 1.0.4 version. Please update.


ReplyQuote
pxt-wpforo-2018
(@pxt-wpforo-2018)
Active Member Customer
Joined: 9 months  ago
Posts: 7
10/01/2018 2:07 am  

Thank you Tom. I have updated the plugin and I see that the exception no longer shows. I'll retest the other scenarios I found problems with, which seemed to relate to having default fields in the filter search, and some other problems I saw, so please don't close this thread. I appreciate your work and I'm excited to be testing my new addon again.


ReplyQuote
pxt-wpforo-2018
(@pxt-wpforo-2018)
Active Member Customer
Joined: 9 months  ago
Posts: 7
10/01/2018 2:44 am  

Now that the exception has gone, I can see the issues in the search results.

  • Set Members Search Type to Filter
  • Reset all custom fields
  • In the members search page, filtering by Display Name "Fred" returns "Fred", OK
  • Now create a custom field of data type Text
  • In the members search page, filtering by Display Name "Fred" returns "Fred", OK
  • Now add the custom field to the members search page
  • In the members search page, filtering by Display Name "Fred" returns all records

When there are both default fields and custom fields in the members search page, the search produces too many records.


ReplyQuote
Tom
 Tom
(@tomson)
Support Team Admin
Joined: 3 years  ago
Posts: 2744
10/01/2018 2:47 am  

Ok, thank you, we'll check this as well.


ReplyQuote
Tom
 Tom
(@tomson)
Support Team Admin
Joined: 3 years  ago
Posts: 2744
11/01/2018 2:03 am  

Hi pxt-wpforo-2018,

Please update to 1.0.5 version.


ReplyQuote
pxt-wpforo-2018
(@pxt-wpforo-2018)
Active Member Customer
Joined: 9 months  ago
Posts: 7
11/01/2018 2:52 am  

Thank you Tom. I have updated to 1.0.5 and I see the specific search in my post above now produces the correct records.

Another search on the same fields does not work as expected. Using the default field Display User and a custom field called Test; in the user profile of Fred, set the Test field to value "Test".

  • Search Display Name = "Fred", Test = "Test", returns Fred, OK.
  • Search Display Name = "Fred", Test = "Banana",  returns no records, OK.
  • Search Display Name = "Banana", Test = "Test", returns Fred
  • Search Display Name = "Banana", Test = "Banana", returns no records, OK

When the Display Name is a match, but the custom field is not a match, no records should result.


ReplyQuote
Tom
 Tom
(@tomson)
Support Team Admin
Joined: 3 years  ago
Posts: 2744
11/01/2018 2:55 am  

When the Display Name is a match, but the custom field is not a match, no records should result.

The search condition is OR not AND. We'll consider to add condition changer in future releases.


ReplyQuote
pxt-wpforo-2018
(@pxt-wpforo-2018)
Active Member Customer
Joined: 9 months  ago
Posts: 7
11/01/2018 3:14 am  

No end user is ever going to figure out the inconsistencies between default fields and custom fields.

The two default fields work together as an AND. The default and custom fields now work as OR. This can't be right.

Display Name = "Fred", Nickname = "mark" produces no records, as an AND, as users will expect.

Display Name = "Fred", Test = "Banana" produces Fred, as an OR, as users will never figure out. The OR is different from example search forms that users see commonly.


ReplyQuote
pxt-wpforo-2018
(@pxt-wpforo-2018)
Active Member Customer
Joined: 9 months  ago
Posts: 7
11/01/2018 3:45 am  

I just checked what happens when there are multiple custom fields on the search form. The custom fields work together as an AND, as users will expect. The default fields work together as an AND, as users will expect.

Please don't be offended, but I am sure it should all be AND, consistently.


ReplyQuote
Tom
 Tom
(@tomson)
Support Team Admin
Joined: 3 years  ago
Posts: 2744
11/01/2018 2:46 pm  

Thank you for these information.

I think both are important. We'll check this and find some solution in future releases.


ReplyQuote
Share: